Navigation screen: Add .editor-styles-wrapper #23736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surrounds the Navigation screen's BlockList with a .editor-styles-wrapper div. This allows CSS rules which override default block styling to work.
noisysocks
added
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Approving because this solves the problem, and it's the quickest approach to do so. But I think ultimately this is a problem of excessive specificity in our CSS, and the way editor-styles-wrapper is now being used to increase specificity, or to target the editor specifically, feels the opposite direction to our aim of having the editor mirror the front end exactly.
Not sure if there's been any conversation about this, and there don't seem to be any rules against using that class, but because it started as an automated class added to theme editor styles, and hopefully editor styles will become unnecessary at some point, using it elsewhere will make it harder to remove when we no longer need it for that purpose.
|
Thanks @tellthemachines! Unsure if there's been any recent wider discussion around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #22656.
Fixes bug described in #22656 (review).
Surrounds the Navigation screen's
BlockListwith a.editor-styles-wrapper. This is what is suggested in the docs.Doing this allows CSS rules which attempt to override default block styling to work in the Navigation screen. This includes the
margin: 0which fixes the issue described in #22656 (review):gutenberg/packages/block-library/src/navigation/editor.scss
Lines 12 to 14 in 791be97
Before
After