Refactor FormFileUpload to use React hooks #22894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
jorgefilipecosta
as code owners
Soean
added
the
Good First Review
|
Size Change: -36 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
chrisvanpatten
added
the
[Feature] Media
youknowriad
added
the
[Type] Code Quality
ellatrix
reviewed
Jun 4, 2020
| type="file" | ||
| ref={ ref } | ||
| multiple={ multiple } | ||
| style={ { display: 'none' } } |
There was a problem hiding this comment.
I've often wondered: do element components benefit from a constant style reference, or do you think it doesn't matter?
There was a problem hiding this comment.
I don't know tbh. I think React has some internal shallow rendering techniques but I suspect it extends to common props like style (it's a guess)
ellatrix
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #22890
Refactored FormFileUpload to use hooks.
Testing instructions