ESLint Plugin: Relax check for i18n-text-domain rule #21928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] ESLint plugin
|
Size Change: 0 B Total Size: 817 kB ℹ️ View Unchanged
|
swissspidy
approved these changes
Apr 28, 2020
|
Probably should be a CHANGELOG.md entry for this? |
|
Yes, an important one, thanks for catching 👍 |
|
Done in cbcb619. |
gziolo
added a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21920.
Tries the approach suggested by @swissspidy:
Now that I read it again, I want to double-check if we can bail early when the
allowedTextDomainis not provided ... 🤣How has this been tested?
npm run lint-jsstill works with Gutenberg – it uses local overridenpm run lint-jsdoesn't fail when a random text domain is added to translations when the local override is removed.npm run test-unitworks with newly added unit tests.