Edit unsupported blocks in a RN web view #21832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile, unsupported blocks cannot be shown in the React Native editor. To allow users to edit these blocks, we use a web view to show a web editor and allow the user to manipulate the block there before loading its contents back into the mobile editor.
guarani
changed the title
2 tasks
|
Size Change: 0 B Total Size: 845 kB ℹ️ View Unchanged
|
etoledom
added
the
Mobile App - i.e. Android or iOS
etoledom
reviewed
Apr 23, 2020
| uri: | ||
| 'https://cruisinglamb.wordpress.com/wp-admin/post-new.php', | ||
| } } | ||
| injectedJavaScript={ scriptToInject } |
There was a problem hiding this comment.
Do we have more control over when can we inject JS code?
I have noticed that to avoid some flickering of UI or CSS overrides we will need to inject some snippets as early as possible and others as late as possible.
There's for example this little flash of the WP Admin Bar while the page is loading. So we should inject the "hide WP Admin Bar" CSS earlier. But then the Editor CSS will override the Gutenberg top bar changes since it loads later. And to avoid that, we need to inject the Editor CSS as late as possible (when everything is loaded).
|
Closing this in favor of wordpress-mobile/gutenberg-mobile#2063 |
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to update unsupported blocks via a new modal web editor.
How has this been tested?
Screenshots
Types of changes
Checklist: