-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try/enable global styles #21346
Try/enable global styles #21346
Conversation
Size Change: +1.49 kB (0%) Total Size: 885 kB
ℹ️ View Unchanged
|
@nosolosw This is working for me. To clarify, it works even if a theme does not declare any support. You mentioned: Is |
@johnstonphilip thanks for testing! Yeah, I suggest testing with both a theme that doesn't declare support (to highlight how core settings would be still available) and with one that has support (to highlight how themes can override them). Added a numbered list, hoping it makes the testing instructions clearer. |
We're reverting the addition of CSS variables at the block level at #21428 so this PR no longer makes sense as it is, so I'm closing it for the time being. |
Extracted from #20530 (comment)
This PR enables the Global Styles mechanism (inline the CSS properties) without requiring theme support or the FSE experiment.
How to test
experimental-theme.json
.experimental-theme.json
to be something really gross: red for colors, 5 for line-height, etc.p
,h2
, andh3
elements. Some that you may check are: