Merged
Conversation
sirreal
added
[Status] In Progress
75 tasks
sirreal
force-pushed
the
add/types-redux-routine
branch
from
35b70ba to
62ca114
Compare
sarayourfriend
force-pushed
the
add/types-redux-routine
branch
from
62ca114 to
d531fcc
Compare
Contributor
|
Ah shoot, I blew away your earlier attempt @sirreal Do you happen to have a local copy of this still that you could repush? I didn't realize I was pushing to an already existing branch 🤦 |
|
Size Change: +665 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Contributor
|
Never mind, I'll be merging our approaches, figured out how to fix it. Sorry for the ping! |
sarayourfriend
force-pushed
the
add/types-redux-routine
branch
from
d531fcc to
ef317bb
Compare
Contributor
|
I've update the |
sirreal
commented
Jun 22, 2021
| @@ -0,0 +1,17 @@ | |||
| declare module 'rungen' { | |||
Member
Author
There was a problem hiding this comment.
@youknowriad Would you be interested in publishing types for rungen? We could include the types in the package without requiring any code changes.
Contributor
There was a problem hiding this comment.
Whatever works best for you. I'm also happy to add collaborators on that package, I didn't touch it for some time now 😬
Member
Author
There was a problem hiding this comment.
Thanks. Providing the types from the library itself seems ideal to me, although we don't need to wait for it here.
ciampo
reviewed
Jun 22, 2021
ciampo
reviewed
Jun 22, 2021
5 tasks
sarayourfriend
force-pushed
the
add/types-redux-routine
branch
from
280678c to
5037f58
Compare
ciampo
reviewed
Jun 23, 2021
sarayourfriend
force-pushed
the
add/types-redux-routine
branch
from
5037f58 to
2b21f85
Compare
sirreal
commented
Jun 24, 2021
Member
Author
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
I have one concern about introducing a new dependency on redux
| { "path": "../priority-queue" }, | ||
| // Needs to be added once it is typed | ||
| // { "path": "../redux-routine" } | ||
| { "path": "../redux-routine" } |
sirreal
commented
Jun 25, 2021
Member
Author
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
I can't approve because I opened this originally, but it looks good. Thanks for getting it over the line @sarayourfriend!
👍 ✅ 🚢
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Work in progress
Help is welcome 🙂
Add types to
@wordpress/redux-routine.Part of #18838
How has this been tested?
Screenshots
Types of changes
Checklist: