Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMobile release v1.22.0 #20062

Merged
merged 120 commits into from
Feb 10, 2020
Merged

RNMobile release v1.22.0 #20062

merged 120 commits into from
Feb 10, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 6, 2020

Description

This PR contains the changes included in the v1.22.0 release of the native mobile port of the block editor. It's targeting the rnmobile/releases-2020 branch and won't be updated from master while the release is ongoing, to avoid bringing in new changes from master.

After this PR gets approved and merged, a follow up PR will bring all the changes back to master.

How has this been tested?

Using this gutenberg-mobile PR.

Types of changes

All changes were individually tested and merged as part of their respective PRs.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

epiqueras and others added 30 commits January 20, 2020 14:31
* Use Select: Fix render queue issues.

* Use Select: Make `isMounted` more informative.

* Framework: Reset lockfile changes to dependencies

Co-authored-by: Andrew Duthie <[email protected]>
* Add text color selector to group block to allow setting a text colour that applies to all children of the group to avoid having to set text colour on every individual child
* Block Editor: Handle LinkControl submission via form handler

* E2E Tests: Unskip intermittent buttons test failure
* Added conditions and new translation strings for BlockMover

* Moved translator comments into sprintf function
* Add Placeholder story for storybook

* Update storybook test snapshot
* Framework: Use fixed version of checkout action

Avoid unintended breaking changes. To a lesser extent, helps clarify that this tag refers to the _version of the action_, not the branch being checked out.

* Framework: Configure PR automation checkout to master branch
* Multi-select: don't focus first selected block

* Move CopyHandler outside WritingFlow

* Fix click appender

* Remove useless line
* Build: Include JSON files

* Zip build script: Include json files in `build/block-library/blocks/`

Co-Authored-By: Jorge Bernal <[email protected]>

Co-authored-by: Jorge Bernal <[email protected]>
* makes appenders visible only for the current selection

* adds smaller footprint to appenders in navigation, only shows them if item has descendants

* align appender to level of the menu item, remove useless CSS
#19752)

* Core-data: do not publish outdated state to subscribers during updates

Calling `saveEntityRecord` with an update does the following:

1. Calls `getEntityRecord` to fetch the current persisted state of the entity record
2. Calls `receiveEntityRecords` with the new up-to-date state to render the updates
3. Sends an API fetch with the update patch to persist the update
4. Calls `receiveEntityRecords` again with the new up-to-date *persisted*
state

The issue here, is that point 1 (Calling `getEntityRecord`) not only fetches
the persisted state, but it also internally calls `receiveEntityRecords` itself .
This results in the persisted outdated server state to be rendered
on the UI, causing a flickering effect, that jumps pack when point 2
takes turn.

This commit removes the call to getEntityRecord, and instead, it just
calls receiveEntityRecords with the local up-to-date state of the entity
record. This fixes the flickering issue.

* Core-data: update tests to match saveEntityRecord yeilded actions

Given `saveEntityRecord` no longer selects `getEntityRecord`,
which itself triggers a SELECT action, two SELECTs are no longer
yielded. This commit removes the expectation of these two SELECTs.

* Core-data: Introduce getEntityRecordNoResolver selector

To allow saveEntityRecord access the latest local full version
of an entity without issung an API request. This prevents
propogating outdating states to subscribers when
saveEntityRecord is called.

See: #19752 (comment)

* Address review comments at #19752:

1. Capitalize alll added comment messages
2. Alias getEntityRecord with getEntityRecordNoResolver instead of copying it
3. Use describe.each instaed of looping manually in selectors tests
* Initialize setting in the nav block settings panel

* Add submenu icon

* Register "showSubmenuIcon" attributes

* Add submenu icon to front-end of the page

* Update submenu icon setting description

* Don't use <span> for RichText element

* Isolate NavigationLink icons

* Clean up a little

* Use <span> for NavigationLink contents

* Rename `$level_zero` to `$is_level_zero`

* Add missing spaces

* Update submenu icon selector in style.scss

* Add comment about span-wrapping

* Fix phpcs errors

* Remove unused styles

* Fix failing e2e tests

* Update failing snapshots
* Fix error message sizing + alignment in Embed Placeholder

* Fix Table placeholder input vs button alignment

* Adjust spacing between error message and buttons
* Block popover: allow scrolling over

* Clean up

* Fix overlapping inserter popover

* Better comment
* Multi select: keep selection after move

* Add e2e test

* Change e2e test

* Address feedback

* Fix snapshots
* Add flag for determining if running on Android

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount
@cameronvoell cameronvoell self-requested a review February 10, 2020 20:11
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit 0a3009e into rnmobile/releases-2020 Feb 10, 2020
@hypest hypest deleted the rnmobile/release-v1.22.0 branch February 10, 2020 20:19
@hypest
Copy link
Contributor Author

hypest commented Feb 10, 2020

Note, the merge commit to rnmobile/releases-2020 is not helpful as along with the squash-on-merge policy in this repo it messes up git when trying to merge to/from master. I will force-push rnmobile/releases-2020 to remove the merge commit and "enable" the branch to cleanly be updated for the next mobile releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.