Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for WordPress 5.3 RC 4 #18288

Merged
merged 5 commits into from
Nov 5, 2019
Merged

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Nov 5, 2019

Description

Cherry picks already included:
#18183
#18194
#18230
#18275
#18287

jasmussen and others added 3 commits November 5, 2019 14:24
* Fix postmeta radio regression.

This PR fixes #18181.

The regression was caused due to a margin added to the pseudo element which was not necessary for the radio buttons.

* Only apply to side-sortables.
…k invalid (#18194)

* Fix: setting a preset color on pullquote default style makes the block invalid.

* Updated deprecation to keep the colors
Floated images had special rules for the mover control. These are no longer necessary, and indeed created a buggy looking control.
@jorgefilipecosta jorgefilipecosta added the [Type] Project Management Meta-issues related to project management of Gutenberg label Nov 5, 2019
epiqueras and others added 2 commits November 5, 2019 16:07
* Editor: Fix move to trash redirect save race conditions.

* Editor: Add e2e test.

* Editor: Expand comment.

* Fix BrowserURL capitalization

* Revert "Editor: Add e2e test."

This reverts commit 4d58c79.
* Revert img, iframe styles to block editor container scope

* Block Library: Remove all vanilla styles

* Block Library: Restore non-theme front-end margins for figcaption
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through all the test scenarios described in the referenced pull requests / issues and it all appears to work well 👍

@jorgefilipecosta jorgefilipecosta merged commit bd07d21 into wp/5.3 Nov 5, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/bug-fixes-5.3-rc.4 branch November 5, 2019 16:47
@mcsf
Copy link
Contributor

mcsf commented Nov 5, 2019

Applied in WordPress Core in https://core.trac.wordpress.org/ticket/48502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants