Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block navigator to sidebar panel for nav block #18202

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Add block navigator to sidebar panel for nav block #18202

merged 2 commits into from
Oct 31, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Oct 31, 2019 •
edited
Loading

Description

Closes #18190

Adds the navigator to the block sidebar panel

How has this been tested?

  1. Add a Navigation Block
  2. Add some menu items
  3. Check the sidebar of the Navigation Block
  4. Expect to see the Block Navigator

Screenshots

Screen Shot 2019-10-31 at 3 21 21 pm

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Navigation Affects the Navigation Block labels Oct 31, 2019
@talldan talldan self-assigned this Oct 31, 2019
@talldan
Copy link
Contributor Author

talldan commented Oct 31, 2019

I like this. It might also be good to display it on the menu items in the same place (and still scoped to the Navigation Menu) so that it's possible to navigate back and forth.

@draganescu
Copy link
Contributor

I feel like the navigation structure should remain in the sidebar for the submenu items too, maybe I expect that it is there while I am in the menu and it always shows the current item.

@talldan
Copy link
Contributor Author

talldan commented Oct 31, 2019

@draganescu I've experimented with that over on #18203.

The implementation is very hacky as I ran out of time and just did whatever was quickest to show the concept.

@talldan talldan mentioned this pull request Oct 31, 2019
Closed
draganescu
draganescu approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great.

@draganescu draganescu merged commit 60d666e into master Oct 31, 2019
@draganescu draganescu deleted the add/navigator-to-nav-sidebar branch October 31, 2019 17:43
daniloercoli added a commit that referenced this pull request Nov 5, 2019
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
e21e76e 
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
  ...
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
@talldan talldan mentioned this pull request Aug 8, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@noisysocks noisysocks Awaiting requested review from noisysocks

@mtias mtias Awaiting requested review from mtias

@shaunandrews shaunandrews Awaiting requested review from shaunandrews

Assignees

@talldan talldan

Labels
[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.

Navigation Block: Show block navigator in the sidebar as well.
3 participants
@talldan @draganescu @youknowriad