Update: Use minimum height instead of height for cover minimum height label #17634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
epiqueras
approved these changes
Sep 27, 2019
epiqueras
deleted the
update/use-minimum-height-instead-of-height-for-cover-minimum-height
branch
|
This seems like something that should be included in WordPress 5.3. |
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply changes the cover input minimum height input field label. When changing that value users are setting a minimum heigh property and not a height property we are using the wrong label and this brings confusion as noted on issue #17582.