Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom gradient component #17603

Merged
merged 7 commits into from
Dec 5, 2019
Merged

Add custom gradient component #17603

merged 7 commits into from
Dec 5, 2019

Commits on Dec 5, 2019

  1. Post rebases fixes (+6 squashed commits) 

    Squashed commits:
[4ee9051258] Avoid moving over other control points
[479d199cfe] Add mechanism that allows themes disabling custom gradients.
[37bc638743] Polish gradients further, and the gradient stops.

Polish some of the gradient stop dimensions.

Tweak the gradient presets to have fewer in the same hue.
[9778bef873] Polish, better gradients, better spacing.

This commit improves a few things:

- It better spaces the items, so that there can be 6 swatches on a line. And works both with and without scrollbar.
- It polishes the gradient customizer so that the handles are perfectly placed in the curves of the slider.
- It removes a few of the more muddy gradient presets.
[0c23c3d962] Improved a11y
[c0fd4d6b97] Code refactor (+2 squashed commits)
Squashed commits:
[cc33664] Refactor and improvements
[f044457] Add: Custom gradient component
    @jorgefilipecosta
    jorgefilipecosta committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    d62b902 View commit details
    Browse the repository at this point in the history

  2. Refactor to state based

    @jorgefilipecosta
    jorgefilipecosta committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    4a51675 View commit details
    Browse the repository at this point in the history

  3. Add tests to the gradient serializer

    @jorgefilipecosta
    jorgefilipecosta committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    09a6ceb View commit details
    Browse the repository at this point in the history

  4. Update packages/components/src/custom-gradient-picker/control-points.js 

    Co-Authored-By: Miguel Fonseca <[email protected]>
    @jorgefilipecosta @mcsf
    jorgefilipecosta and mcsf committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    c6d2ae7 View commit details
    Browse the repository at this point in the history

  5. Update packages/components/src/custom-gradient-picker/control-points.js 

    Co-Authored-By: Miguel Fonseca <[email protected]>
    @jorgefilipecosta @mcsf
    jorgefilipecosta and mcsf committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    e6e40ed View commit details
    Browse the repository at this point in the history

  6. Clean up listeners on unmout

    @jorgefilipecosta
    jorgefilipecosta committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    7c6c5c0 View commit details
    Browse the repository at this point in the history

  7. Revert include custom gradient picker on gradient picker component

    @jorgefilipecosta
    jorgefilipecosta committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    dbb5f8b View commit details
    Browse the repository at this point in the history