Remove the forced gray scale from the category icons #17415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta and
talldan
as code owners
youknowriad
added
the
[Release] Do Not Punt
|
While I'm open to this PR because the initial greyscale solution introduced a new problem, I also wanted to note that there's also a cognitive overload concern with this revert because the inclusion of colored icons draws visual attention when it may not be needed. That said, if we found a way to make sure all icons were the same value of dark grey, that would be a better solution. I'm not entirely sure how to solve this technically right now so as mentioned this PR is probably a good way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert #16163
#16163 was an attempt to reduce the cognitive load from the category icons in the inserter but we got some feedback that it makes it a bit harder to recognize block sources without these colors.
A11y wise, the loss of color contrast can affect the visibility of some icons;
cc @mapk @mtias