Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Github Actions to the new YAML syntax #16981

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

youknowriad
Copy link
Contributor

I just used the Github tool to migrate our Github actions workflows to the new yaml syntax.

@youknowriad youknowriad self-assigned this Aug 9, 2019
@youknowriad youknowriad added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 9, 2019
Copy link
Contributor

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it was done by an automated tool i don't think there should be any problems, and I don't think we can test it before merge, so all good i guess.

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the updated actions don't work on the actual PR making the change 😏

Merge away and see what happens next PR :yolo:

@youknowriad
Copy link
Contributor Author

Let's see :P

@youknowriad youknowriad merged commit 4af9221 into master Aug 9, 2019
@youknowriad youknowriad deleted the migrate/actions branch August 9, 2019 13:05
@ntwb
Copy link
Member

ntwb commented Aug 9, 2019

@youknowriad lol, and, nope, no actions queued on the #16985 PR

@senadir
Copy link
Contributor

senadir commented Aug 9, 2019

a lot of them did in #16984

@ntwb
Copy link
Member

ntwb commented Aug 9, 2019

Hehehehe, so no change in behavior of the actions then ;)

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019
@noisysocks
Copy link
Member

I think @talldan convinced me that all our project automation actions should be in one workflow. We should also look into making them JavaScript-based instead of Docker-based. I might have a play with it on Wednesday 🙂

@talldan
Copy link
Contributor

talldan commented Aug 12, 2019

I was thinking about this as a way to reduce the amount of checks in PRs by a factor of 3.

However, I just noticed when I went to the 'actions' tab in Github (https://github.com/WordPress/gutenberg/actions), that a little popup showed up asking me if I wanted to enable the new actions from this PR. I clicked enable. Let's see if that makes a difference. (edit: Yep, looks like it has migrated us over to the new logging - https://github.com/WordPress/gutenberg/pull/16957/checks?check_run_id=190959011)

@youknowriad
Copy link
Contributor Author

youknowriad commented Aug 12, 2019

We should rename the checks titles to be smaller :)

@talldan
Copy link
Contributor

talldan commented Aug 12, 2019

I've spotted some issues. It looks like exit code 78 isn't supported any more by actions—created PR #17002, but the filter we're using also uses 78, so still seeing checks failing.

Multiple checks are still showing. The logging shows that actions are being triggered multiple times for any of the following things that can happen to a PR:
assigned, unassigned, labeled, unlabeled, opened, edited, closed, reopened, synchronize, ready_for_review, locked, unlocked

Yet to discover if there's a way to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants