-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the Github Actions to the new YAML syntax #16981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it was done by an automated tool i don't think there should be any problems, and I don't think we can test it before merge, so all good i guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the updated actions don't work on the actual PR making the change 😏
Merge away and see what happens next PR :yolo:
Let's see :P |
@youknowriad lol, and, nope, no actions queued on the #16985 PR |
a lot of them did in #16984 |
Hehehehe, so no change in behavior of the actions then ;) |
I think @talldan convinced me that all our project automation actions should be in one workflow. We should also look into making them JavaScript-based instead of Docker-based. I might have a play with it on Wednesday 🙂 |
I was thinking about this as a way to reduce the amount of checks in PRs by a factor of 3. However, I just noticed when I went to the 'actions' tab in Github (https://github.com/WordPress/gutenberg/actions), that a little popup showed up asking me if I wanted to enable the new actions from this PR. I clicked enable. Let's see if that makes a difference. (edit: Yep, looks like it has migrated us over to the new logging - https://github.com/WordPress/gutenberg/pull/16957/checks?check_run_id=190959011) |
We should rename the checks titles to be smaller :) |
I've spotted some issues. It looks like exit code 78 isn't supported any more by actions—created PR #17002, but the filter we're using also uses 78, so still seeing checks failing. Multiple checks are still showing. The logging shows that actions are being triggered multiple times for any of the following things that can happen to a PR: Yet to discover if there's a way to improve this. |
I just used the Github tool to migrate our Github actions workflows to the new yaml syntax.