Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade #16937
Conversation
gziolo
requested review from
ajitbohra,
nerrad,
oandregal,
ntwb and
youknowriad
as code owners
gziolo
changed the title
| @@ -47,7 +47,7 @@ | |||
| "jest-puppeteer": "^4.3.0", | |||
| "minimist": "^1.2.0", | |||
| "npm-package-json-lint": "^3.6.0", | |||
| "puppeteer": "1.19.0", | |||
| "puppeteer": "^1.19.0", | |||
There was a problem hiding this comment.
@gziolo Just wanting to confirm that adding the ^ caret here is deliberate?
There was a problem hiding this comment.
In addition, it enables ranged for puppeteer dependency so we could update it more often with ease.
Yes, I also included it in the CHANGELOG file. In general, while working on upgrade we started at 1.15 and didn't see any issues up to 1.19, so there is no need to be worried about it.
There was a problem hiding this comment.
Why do we keep these if there is a lock file? Why to get rid of all ^ entirely?
There was a problem hiding this comment.
it's not for us, it's for those who consume this package on npm. They shouldn't be forced to use the same version we do.
There was a problem hiding this comment.
Thanks, all makes sense, merge when green 💯
gziolo
force-pushed
the
update/scripts-changelog
branch
from
cbb8056
to
018456c
Compare
…#16937) * Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade * Scripts: Enable semver friendly updates to puppeteer dependency
…#16937) * Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade * Scripts: Enable semver friendly updates to puppeteer dependency
Description
Follow-up for #16875.
This PR adds the missing CHANGELOG entries for
@wordpress/scriptspackage.In addition, it enables ranged for
puppeteerdependency so we could update it more often with ease.