Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental
ResponsiveBlockControl
component #16790Add experimental
ResponsiveBlockControl
component #16790Changes from all commits
23807cf
95bfae8
dd64a53
8116762
4ca0fc5
fe7c77d
e051305
9c6e8b2
f2d1bfc
aa1ec5f
eb5e9ba
bec9001
1907640
17eec18
c9c5e08
eb9c5f3
238d541
1af87b9
51b43a6
20a95b4
a64c2cd
9926612
d210cfe
b81e605
8605087
3ac118d
045dd49
b5bfc06
5c9841c
b2bea8c
827bb82
059b5a5
ce3be6f
195aef5
e821dc9
863783c
8ebbd2c
64e719f
e6aad72
48529f7
d72e6af
a46f406
15da1b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note here about BEM convention as at: #17846 (comment)
Also:
is-responsive
for the other condition, and for this one, simply omitting it.The second point would actually enable us to simplify this implementation, where currently there is code duplication for
block-editor-responsive-block-control__group
largely because of how this class is assigned. With the above changes, it could become a unified wrapper of:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assignment of
hidden
here is effectively dead code, because thisdiv
is only rendered inside the condition ofisResponsive && <div />
.