Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table column and row selection #16493

Closed
wants to merge 9 commits into from
Closed

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jul 10, 2019

Status: This is blocked by #17084, better keyboard nav is required for accessibility of the column/row selection buttons in this PR

Description

Closes #16294

This is an early exploration of adding buttons for selecting entire table/columns/rows in the table block.

At the moment I'm trying a few different approaches. In the current version, while you can select columns/rows or the entire table, you can't actually do anything with the selection. 😁

Update: you can now insert columns/rows before/after the selected columns/rows.

How has this been tested?

Screenshots

table-select

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan self-assigned this Jul 10, 2019
@talldan talldan added [Block] Table Affects the Table Block [Type] Enhancement A suggestion for improvement. labels Jul 10, 2019
@talldan talldan mentioned this pull request Jul 10, 2019
5 tasks
@talldan talldan force-pushed the add/table-row-column-selection branch from af38545 to 3576b26 Compare July 12, 2019 09:16
@mapk
Copy link
Contributor

mapk commented Jul 24, 2019

I know this is in early stages, so this is just an early design review 😉

I'm really enjoying the ability to select an entire row or column. It's such a needed improvement!

  1. It would be great to hide all the row/column selection buttons when the block is not selected. I'd like to see the Table aligned with the rest of the content as it should be when not selected.

  2. There are a lot of table icons in view. Maybe we can change the "Edit" icon to something like the pencil icon instead?

table-icons

  1. A selected row/column shouldn't reveal the hover state b/c it can't be interacted with at this point.

table-selection-state

  1. I'd also ensure the button and the column/row borders align as well.

Screen Shot 2019-07-24 at 10 56 00 AM

@mapk mapk added the [Status] In Progress Tracking issues with work in progress label Jul 24, 2019
@talldan
Copy link
Contributor Author

talldan commented Jul 25, 2019

Thanks @mapk, great to get some feedback, really good points, will look into making those changes. 😄

@talldan talldan mentioned this pull request Aug 8, 2019
5 tasks
@talldan talldan added [Status] Blocked Used to indicate that a current effort isn't able to move forward and removed [Status] In Progress Tracking issues with work in progress labels Dec 5, 2019
@ocean90
Copy link
Member

ocean90 commented May 12, 2020

The blocking issue has been fixed in #22105.

@talldan talldan removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 12, 2020
Base automatically changed from master to trunk March 1, 2021 15:42
@talldan talldan closed this Jul 19, 2022
@talldan talldan deleted the add/table-row-column-selection branch July 19, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table block: Allow selection of entire rows and columns
3 participants