Hide the columns count control on empty columns block #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Fixes #16343 |
aduth
approved these changes
Jul 12, 2019
| @@ -170,9 +172,7 @@ export function ColumnsEdit( { | |||
| setForceUseTemplate( true ); | |||
| } } | |||
| __experimentalAllowTemplateOptionSkip | |||
| // setting the template to null when the inner blocks | |||
There was a problem hiding this comment.
Seems like this comment is still valid?
| return ( | ||
| <> | ||
| { template && ( | ||
| { ! showTemplateSelector && ( |
There was a problem hiding this comment.
Alternatively, I wonder what it is about choosing columns that causes the issue in the first place. If someone wanted to skip the layout selection and just start setting columns (assuming of an equal width), why prevent them?
There was a problem hiding this comment.
yeah I'm not sure what. I decided to remove the selector not only because of the bug because based on the previous check here. I assumed that removing the inspector controls was an intentional behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small regression introduced by #16129
closes #16343
When the columns block is in the "setup state", the columns count range control should be hidden.