Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding/deleting table columns across sections #16410

Merged
merged 4 commits into from
Jul 4, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jul 3, 2019

Description

Fixes #16046

Ensures adding table cells/columns results in cells being added across table sections (in the header, body and footer)..

How has this been tested?

  • Added unit tests
  • Added e2e tests

Manual Testing steps

  1. Navigate to Posts > Add New
  2. Insert a Table block
  3. Choose Column/Row Count and press "Create Table" (specific values do not matter)
  4. Toggle "Header section" in the Block Inspector "Table Settings" sidebar
  5. Select a cell in the table
  6. From the "Edit Table" Block Toolbar menu, select "Add Column Before" or "Add Column After"
  7. Note that the last column does not include cells under its header

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Table Affects the Table Block labels Jul 3, 2019
@talldan talldan self-assigned this Jul 3, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well for me. Thanks for the fix.

@talldan talldan merged commit 9de5431 into master Jul 4, 2019
@talldan talldan deleted the fix/adding-table-columns-across-sections branch July 4, 2019 10:43
@ellatrix
Copy link
Member

ellatrix commented Jul 4, 2019

Ah, @youknowriad beat me to leaving a review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Library: Table: Inserting new column with header present lacks cells
3 participants