Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: fix inline toolbar position #16299

Merged
merged 1 commit into from
Jun 26, 2019
Merged

RichText: fix inline toolbar position #16299

merged 1 commit into from
Jun 26, 2019

Conversation

ellatrix
Copy link
Member

Description

Correction after #15212.
See #16295 (comment).

This PR restores inline toolbar positioning.

How has this been tested?

Insert an image block, focus caption, ensure inline toolbar is positioned correctly.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Regression Related to a regression in the latest release Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jun 26, 2019
@ellatrix ellatrix added this to the Gutenberg 6.1 milestone Jun 26, 2019
@ellatrix ellatrix self-assigned this Jun 26, 2019
@youknowriad youknowriad requested a review from kjellr June 26, 2019 12:38
kjellr
kjellr approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the latest changes from #16295 in locally to test alongside those:

Screen Shot 2019-06-26 at 10 08 34 AM

This works well! Thanks for the fix.

@ellatrix
Copy link
Member Author

Thanks!

@ellatrix ellatrix merged commit b2690fa into master Jun 26, 2019
@ellatrix ellatrix deleted the fix/rich-text-inline-toolbar branch June 26, 2019 14:45
This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellr kjellr kjellr approved these changes

@aduth aduth Awaiting requested review from aduth

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@etoledom etoledom Awaiting requested review from etoledom

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@ellatrix ellatrix

Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @kjellr