Change wording, add a second block to the template and mention block.… #16237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json as a resource for attributes
gziolo
added
[Type] Developer Documentation
draganescu
requested changes
Aug 5, 2019
| The optional attributes that can be set vary per block type. For a quick overview of the attributes of core block type, you can often check the block type's accompanying block.json file. For example, [these lines](https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/audio/block.json#L4-L37) describe the attributes of the `core/audio` block. | ||
|
|
||
| **JS example:** | ||
| The following example in JavaScript creates a new custom block using [InnerBlocks](/packages/block-editor/src/components/inner-blocks/README.md) and templates. When this block is inserted, this block creates a set of blocks based off the template. |
There was a problem hiding this comment.
When this block is inserted, it creates a set of blocks based off the template.
| @@ -59,7 +67,8 @@ registerBlockType( 'myplugin/template', { | |||
| }); | |||
| ``` | |||
|
|
|||
| See the [Meta Block Tutorial](/docs/designers-developers/developers/tutorials/metabox/meta-block-5-finishing.md) for a full example of a template in use. | |||
| Templates are especially useful in combination with blocks that store custom post_meta to a post type. See the [Meta Block Tutorial](/docs/designers-developers/developers/tutorials/metabox/meta-block-5-finishing.md). | |||
There was a problem hiding this comment.
The 1st sentence is a bit unclear.
mkaz
added
the
[Status] Stale
|
It looks like this PR was abandoned. I’m closing it for now. It can be reopened at any time with the refreshed code according to the feedback shared. Thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…json as a resource for attributes
#6190
Description
How has this been tested?
Screenshots
Types of changes
Checklist: