-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand explanation of uses for dynamic blocks #16228
Conversation
Gives clearer explanation of dynamic blocks uses. This update especially explains the need to use dynamic blocks if developers want their block updates to be immediately reflected on the front end of the site, instead of Gutenberg's validation process applying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some suggestions, large and small, which attempt to break up the content and also clarify a few pieces of how server-rendered blocks work. Please let me know if you have any questions!
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Show resolved
Hide resolved
All suggestions have been accepted. Co-Authored-By: Chris Van Patten <[email protected]>
Hi. As a first-time contributor I'm not sure if there is anything else I'm supposed to do here. I have accepted all the comments from @chrisvanpatten and have recommitted it 6 days ago. But nothing has happened since. It says another review is required, and there are 5 pending reviewers. Can someone please review and merge these changes? Or is there something else I'm supposed to do? Thanks. |
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Show resolved
Hide resolved
@jodamo5 Sorry, one more quick fix then I'm happy to approve and merge. |
…creating-dynamic-blocks.md Final suggestion accepted. Co-Authored-By: Chris Van Patten <[email protected]>
@chrisvanpatten One of the author tests failed in the build apparently, which seems strange. Can you provide guidance for next steps please? |
restarted the build, it should be unrelated. |
Great. All the checks passed. Can someone merge this please? |
Thanks for your patience, @jodamo5. Looks great; excited to have this improvement in place. |
Description
This update gives a clearer explanation of the uses for dynamic blocks. This update especially explains the need to use dynamic blocks if developers want their block updates to be immediately reflected on the front end of the site, instead of Gutenberg's validation process applying.
How has this been tested?
No code has been changed - just the explanation about dynamic blocks.
For the second use-case example that I have added, I have tested this in Wordpress by creating a dynamic block, and have tested the values it saves into the database.
Types of changes
The existing description of dynamic blocks is extremely limited. The fuller explanation I have written gives far more breadth to the use of dynamic blocks.