Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Narrow down blur on unmount to replaceable only #16151

Merged
merged 5 commits into from
Jun 13, 2019
Merged

[RNMobile] Narrow down blur on unmount to replaceable only #16151

merged 5 commits into from
Jun 13, 2019

Commits on Jun 13, 2019

  1. Remove focus from RichText when unmounting 

    In #15999 this behavior was changed to prevent the keyboard from disappearing
when you press Enter to create a new paragraph.

This worked in that case, but had the side effect of TextInputState still
thinking a dead view had focus, and causing a crash in some scenarios.
    @koke
    koke committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    985897f View commit details
    Browse the repository at this point in the history

  2. Only blur a RichText in replaceable block 

    That RichText won't have the chance to blur earlier so, we need to do it
on unmount. But, non replaceable blocks wont need to blur their RichText
on unmount because that will happen normally in componentDidUpdate().
    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    b439d18 View commit details
    Browse the repository at this point in the history

  3. Rename to an unstable, very goal-named name

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    55f0362 View commit details
    Browse the repository at this point in the history

  4. Compute shouldBlurOnUnmount inside RichText

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    73c60b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'rnmobile/release-v1.7.0' into rnmobile/narrow-blur-on-u… 

    …nmount-to-replaceable
    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    e92f40b View commit details
    Browse the repository at this point in the history