Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/tab-panel): improve className safety by using 'classnames' #16081

Merged
merged 1 commit into from
Jun 11, 2019
Merged

fix(components/tab-panel): improve className safety by using 'classnames' #16081

merged 1 commit into from
Jun 11, 2019

Conversation

dsifford
Copy link
Contributor

Let me know if you have any questions or if I missed something.

Description

This PR does two things:

  1. Improves safety of the interpolation of className for tabs (currently the string undefined will show up if the tab doesn't have the className property defined).
  2. Relaxes the strictness and makes the className property of tab optional.

How has this been tested?

Yes. All tests still pass fine.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@dsifford
fix(components/tab-panel): improve className safety by using classNames
35d98d1 
This commit does two things:
1. Improves safety of the interpolation of className for `tab`s (currently the
   string `undefined` will show up if the `tab` doesn't have the `className`
   property defined).
2. Relaxes the strictness and makes the `className` property of `tab` optional.
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Jun 11, 2019
gziolo
gziolo approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. I agree with the changes proposed 👍

@gziolo gziolo merged commit 6b8eb7a into WordPress:master Jun 11, 2019
@github-actions github-actions bot added this to the Gutenberg 5.10 milestone Jun 11, 2019
@gziolo gziolo modified the milestones: Gutenberg 5.10, Gutenberg 6.0 Jun 11, 2019
@dsifford dsifford deleted the dsifford-fix-make-tabpanel-safer branch June 11, 2019 13:38
This was referenced Jul 16, 2024
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dsifford @gziolo