-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Implement pass-through behavior for Column block #16024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one line which needs to be double checked. Otherwise, code looks good and tests well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there are 2 failing e2e tests. They both seem to be related to the changes introduced.
Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]>
Yeah, while I've not yet looked at the specific failings, in reflection I recall there being some test cases written as assuming the column as a "stop" point for, e.g. ArrowDown. These would need to be updated since that's no longer true. |
We may revisit this in the future, but for now this is not mergeable in its current state. |
Related: #15927
Closes #7694
Partially addresses #15660
This pull request seeks to implement a "pass-through" behavior for blocks.
It is implemented as two parts:
With these changes, it should become impossible to select a Column block either by clicking on it, or by using arrow keys to navigate blocks. It is technically still possible to select a Column block via the Block Navigation menu. I don't personally have an issue with this, since the block is technically still present, and the primary motivation is in solving the usability problems around standard selection interactions (which this achieves).
Blocked: While this pull request is considered complete so far as implementing the pass-through behavior, it would need to be merged only in combination with a separate pull request which would recreate the existing Column attributes customizations of widths and vertical alignment assignment. My plan is to create separate pull requests for these distinct efforts, and merge them all at once only when they have each been approved.
Testing Instructions:
Verify that click and arrow key navigation to a Column block is not possible, but that otherwise behaviors are unaffected: