Correct default appender icon transition jump in Safari #15892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
requested review from
ellatrix,
gziolo,
talldan and
youknowriad
as code owners
jorgefilipecosta
approved these changes
May 30, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #15868, when hovering over the default appender icon to the left of the text field, Safari renders a tiny position jump:
This is likely because the browser tries to shift the animation from the CPU to the GPU, mid-animation. 😕 By providing
will-change: opacity(the newer version of the traditionaltranslateZ(0)hack to fix this), we can tell the browser to render the animation using the GPU right from the start, and avoid this issue:The docs for
will-changerecommend removing this after the animation happens, but I haven't been able to sort out a way to get that working here.