Input Interaction: always reset initial vertical position rect #15624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
noisysocks,
ntwb,
talldan and
youknowriad
as code owners
ellatrix
added
the
[Feature] Writing Flow
ellatrix
commented
May 14, 2019
| await page.keyboard.type( '2' ); | ||
| await page.keyboard.press( 'ArrowUp' ); | ||
| await page.keyboard.press( 'ArrowUp' ); | ||
| await page.keyboard.type( 'x' ); // Should be right after "1". |
ellatrix
added
[Type] Bug
youknowriad
approved these changes
May 14, 2019
ellatrix
force-pushed
the
fix/15604-vertical-nav-h-offset-alt
branch
from
f11bca3
to
fff3aed
Compare
aduth
approved these changes
May 14, 2019
There was a problem hiding this comment.
I'd wonder if there's a different basis (e.g. selection changes) we should be using for determining whether to reset this value other than specific user interactions, which seem more error-prone to try to cover (e.g. selection changes by taps, selections or field values changing programmatically).
In the interim, this seems like the most direct fix to the original issue 👍 In some stress testing, I think it may also help resolve some cases where they may have been buggy even in the original implementation (e.g. accounting for Home or End keys in selection changes).
ellatrix
added a commit
that referenced
this pull request
May 15, 2019
youknowriad
pushed a commit
that referenced
this pull request
May 16, 2019
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #15607.
How has this been tested?
Screenshots
Types of changes
Checklist: