Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table block caption #15554

Merged
merged 11 commits into from
Dec 2, 2019
Merged

Add table block caption #15554

merged 11 commits into from
Dec 2, 2019

Commits on Dec 2, 2019

  1. Initial attempt at table block caption 

    Try using a figcaption for the table caption

Revert "Try using a figcaption for the table caption"

Switch back to a standard table caption

This reverts commit b5f00dd.

Add comment explaining location of RichText

Ensure table cell is deselected when navigating from a table cell to the caption

Styling tweaks

Add an inline toolbar to the caption to match the image block implementation

Adjust margin to match image block

Add e2e test for the table block caption

Refine caption accessibility.

Use a div for the caption content

Update caption to use a figcaption element with aria-labelledby

Update table block deprecation so that it has its own attribute definition

Update existing fixtures and add a new fixture for table captions

Minor refinements

Fix hasCaption logic

Update snapshots

Update comment with latest understanding of issue

Use client id to generate non-clashing caption element id

Update block-transforms fixture

Update test to use a regular expression
    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    9aaa961 View commit details
    Browse the repository at this point in the history

  2. Reuse the captionId when already set as an attribute

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3e05aff View commit details
    Browse the repository at this point in the history

  3. Change style rule to use figcaption selector

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1793afb View commit details
    Browse the repository at this point in the history

  4. Explain use of aria-labelledby

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8f5d4ec View commit details
    Browse the repository at this point in the history

  5. Update deprecation

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    65e2063 View commit details
    Browse the repository at this point in the history

  6. Use RichText for figcaption, strip out a11y hacks

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    91c3e80 View commit details
    Browse the repository at this point in the history

  7. Ensure empty classname is not output onto table element and update sn… 

    …apshots
    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    0265104 View commit details
    Browse the repository at this point in the history

  8. Update raw handling test

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    f3ae751 View commit details
    Browse the repository at this point in the history

  9. Revert "Update raw handling test" 

    This reverts commit f3ae751.
    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a0adac7 View commit details
    Browse the repository at this point in the history

  10. Revert "Ensure empty classname is not output onto table element and u… 

    …pdate snapshots"

This reverts commit 0265104.
    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    9181248 View commit details
    Browse the repository at this point in the history

  11. Update table caption fixtures and deprecations

    @talldan
    talldan committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    6474a17 View commit details
    Browse the repository at this point in the history