Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Package JSON Lint Config: Remove is-plain-obj dependency #14751

Merged
merged 2 commits into from
Apr 1, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"glob": "7.1.2",
"husky": "0.14.3",
"is-equal-shallow": "0.1.3",
"is-plain-obj": "1.1.0",
"jsdom": "11.12.0",
"lerna": "3.11.1",
"lint-staged": "7.3.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/npm-package-json-lint-config/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import isPlainObj from 'is-plain-obj';
import { isPlainObject } from 'lodash';

/**
* Internal dependencies
Expand All @@ -10,10 +10,10 @@ import config from '../';

describe( 'npm-package-json-lint config tests', () => {
it( 'should be an object', () => {
expect( isPlainObj( config ) ).toBeTruthy();
expect( { isPlainObject }( config ) ).toBeTruthy();
} );

it( 'should have rules property as an object', () => {
expect( isPlainObj( config.rules ) ).toBeTruthy();
expect( { isPlainObject }( config.rules ) ).toBeTruthy();
} );
} );