-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move misplaced style imports to editor.css #14607
Move misplaced style imports to editor.css #14607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change. I think given that these styles are styles for internal components used by the "block" block (reusable blocks), their name makes sense and they are being imported in the right file. I would only not import them in the middle of the file and I would add them at the end of the file with a comment saying: "Import styles from internal components used by the blocks.
8741d83
to
33fcb97
Compare
/** | ||
* Import styles from internal editor components used by the blocks. | ||
*/ | ||
@import "./block/edit-panel/style.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be also renamed to editor.scss
if they belong to this group of styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename was applied.
33fcb97
to
243abc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks
243abc7
to
9cfb1a5
Compare
Description
Currently there's this in the front-end
style.css
:I've moved the imports
from
style.scss
toeditor.scss
.Other changes may be desired.
style.scss
toeditor.scss
?block-library/
?