Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emoji in demo content #13969

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix emoji in demo content #13969

merged 1 commit into from
Feb 20, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Feb 20, 2019 •
edited
Loading

Description

The demo content contains and image as an emoji, as replaced by Twemoji. The saved content should not contain these images.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix requested a review from a team February 20, 2019 12:29
@gziolo gziolo added this to the 5.2 (Gutenberg) milestone Feb 20, 2019
@gziolo gziolo added Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Feb 20, 2019
@ellatrix ellatrix changed the title Fix emoji and spacing in demo content Fix emoji in demo content Feb 20, 2019
kjellr
kjellr approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iseulde! 🚢

Verified by switching to code view on the example post.

Before
screen shot 2019-02-20 at 8 40 53 am

After
screen shot 2019-02-20 at 8 40 33 am

@ellatrix
Copy link
Member Author

Thanks!

@ellatrix ellatrix merged commit aa6797c into master Feb 20, 2019
@ellatrix ellatrix deleted the fix/demo-content branch February 20, 2019 13:43
@ellatrix ellatrix mentioned this pull request Mar 4, 2019
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@ellatrix @youknowriad
Fix emoji in demo content (#13969)
613a9a9
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@ellatrix @youknowriad
Fix emoji in demo content (#13969)
1917d51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellr kjellr kjellr approved these changes

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
5.2 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @kjellr @gziolo