Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds placeholder coloring support for mobile's rich text component. #13738

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Adds placeholder coloring support for mobile's rich text component. #13738

merged 2 commits into from
Feb 7, 2019

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 7, 2019 •
edited
Loading

Description

Adds placeholder support for mobile's rich text component.

How has this been tested?

Through this PR: wordpress-mobile/gutenberg-mobile#560

Types of changes

Just wires a few existing properties.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@diegoreymendez diegoreymendez added the [Type] Enhancement A suggestion for improvement. label Feb 7, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 7, 2019
@diegoreymendez diegoreymendez mentioned this pull request Feb 7, 2019
Merged
hypest
hypest approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works fine 👍

@diegoreymendez diegoreymendez changed the title Adds placeholder support for mobile's rich text component. Adds placeholder coloring support for mobile's rich text component. Feb 7, 2019
@daniloercoli
Copy link
Contributor

Should we add placeholderTextColor to PlainText also?

@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 7, 2019
@hypest
Copy link
Contributor

hypest commented Feb 7, 2019

@daniloercoli , you can do that in a separate PR if needed it seems. I will merge this now.

@hypest hypest merged commit e0be6d5 into master Feb 7, 2019
@hypest hypest deleted the try/add-placeholder-support-for-rich-text-mobile branch February 7, 2019 15:32
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Adds placeholder coloring support for mobile's rich text component. (#…
afc910c 
…13738)

* Adds placeholder support for mobile's rich text component.

* Removes an unnecessary line of code.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Adds placeholder coloring support for mobile's rich text component. (#…
cb0dd2f 
…13738)

* Adds placeholder support for mobile's rich text component.

* Removes an unnecessary line of code.
This was referenced Jul 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@diegoreymendez diegoreymendez

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
5 participants
@diegoreymendez @daniloercoli @hypest @youknowriad @gziolo