Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "we" from messages #13644

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Remove "we" from messages #13644

merged 3 commits into from
Feb 4, 2019

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Feb 2, 2019

Description

I've removed "we" from messages in embed preview and embed placeholder

closes: #13643

How has this been tested?

This has been tested with "npm test" and manually on Chrome and Firefox

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Copy link
Contributor

@Aurorum Aurorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this wording is ideal.

@@ -24,7 +24,7 @@ const EmbedPlaceholder = ( props ) => {
</Button>
{ cannotEmbed &&
<p className="components-placeholder__error">
{ __( 'Sorry, we could not embed that content.' ) }<br />
{ __( 'Sorry, this content could not be embed.' ) }<br />
Copy link
Contributor

@Aurorum Aurorum Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this makes sense as is. It makes me think twice, personally I'd prefer the use of the word "embedded" for consistency with the other message and because it's more frequently used.

Suggested change
{ __( 'Sorry, this content could not be embed.' ) }<br />
{ __( 'Sorry, this content could not be embedded.' ) }<br />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated. Thanks for show me this mistake. I'm not native/fluent english speaker >.<

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for updating! :)

It looks great to me now.

@Soean Soean added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Feb 3, 2019
Copy link

@lalaithan lalaithan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the wording change.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue 👍

@gziolo gziolo merged commit ee2d5c7 into WordPress:master Feb 4, 2019
@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Feb 4, 2019
@Rahmon Rahmon deleted the fix/13643 branch February 4, 2019 08:27
daniloercoli added a commit that referenced this pull request Feb 5, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Make the modal title styling consistent (#13669)
  Disable navigation block for text mode. (#12185)
  Fix: Linting problem in modal example code (#13671)
  Add myself as a code owner to the annotations (#13672)
  Add more reviewers to CODEOWNERS.md file (#13667)
  Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576)
  Workflow: Add repository CODEOWNERS file (#13604)
  Add a mobile minimum size for form fields (#13639)
  Update edit-save documentation  (#13578)
  Alt image setting (#13631)
  Fix: Allow years lower than 1970 in DateTime component. (#13602)
  Using addQueryArgs to generate Manage All Reusable Blocks link (#13653)
  Bump plugin version to 5.0.0-rc.1 (#13652)
  Update lodash to 4.17.10 (#13651)
  Refreshed PR (#9469)
  Set default values of the width and height input fields according to the actual image dimensions (#7687)
  12647 fix css color picker (#12747)
  Remove "we" from messages (#13644)
  Fix: Font size picker max width on mobile (#13264)
  Fix/issue 12501 menu item aria label
  ...
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* remove "we" from embed preview error message

* remove "we" from embed placeholder

* Change from "embed" to "embedded".
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* remove "we" from embed preview error message

* remove "we" from embed placeholder

* Change from "embed" to "embedded".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "we" from embed preview error message
5 participants