Block API: Parse entity only when valid character reference #13512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
talldan
approved these changes
Jan 29, 2019
aduth
force-pushed
the
fix/12448-normalize-encoded
branch
from
76c0e42
to
895fb27
Compare
aduth
force-pushed
the
fix/12448-normalize-encoded
branch
from
895fb27
to
df99432
Compare
daniloercoli
added a commit
that referenced
this pull request
Jan 30, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (36 commits) Fixes plural messages POT generation. (#13577) Typo fix (#13595) REST API: Remove oEmbed proxy HTML filtering (#13575) Removed unnecessary className attribute. Fixes #11664 (#11831) Add changelog for RSS block (#13588) Components: Set type=button for TabPanel button elements. (#11944) Update util.js (#13582) Docs: Add accessbility specific page (#13169) Rnmobile/media methods refactor (#13554) chore(release): publish chore(release): publish Plugin: Deprecate gutenberg_get_script_polyfill (#13536) Block API: Parse entity only when valid character reference (#13512) RichText: List: fix indentation (#13563) Plugin: Deprecate window._wpLoadGutenbergEditor (#13547) Plugin: Avoid setting generic "Edit Post" title on load (#13552) Plugin: Populate demo content by default content filters (#13553) RichText: List: Fix getParentIndex (#13562) RichText: List: Fix outdent with children (#13559) Scripts: Remove npm run build from test-e2e default run (#13420) ...
|
I tested with |
|
@designsimply Did you confirm to compile the files from that commit by |
|
I thought I had but perhaps I was mistaken! 🤦♀️ I just tested again and it's working, ack sorry for the noise! (Aside: this makes me want a badge in the dev env that shows what level or branch I'm on…) |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Block API: Rename IdentityEntityParser as DecodeEntityParser * Block API: Parse entity only when valid character reference
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Block API: Rename IdentityEntityParser as DecodeEntityParser * Block API: Parse entity only when valid character reference
aduth
added
the
[Feature] Block Validation/Deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12448
Supersedes #13406
This pull request seeks to resolve an issue where certain HTML strings may result in a block being incorrectly marked as invalid.
Implementation notes:
The root issue is that in the HTML tokenization which occurs during block validation, the entity decoder wrongly evaluates invalid character references.
For example, given the markup:
Previously, the entity decoder would wrongly produce a value for every segment of text between
∧. With this string, producing a value for the segmentTest</h2><h2>Test &would confuse the tokenizer into considering the entire string as a continuous set of character data, thus missing the EndTag (</h2>) and StartTag (<h2>) within.Testing instructions:
Repeat steps to reproduce from #12448 (comment), verifying that no block invalidation occurs.
Ensure unit tests pass:
cc @fastlinemedia