Update IconButton readme #13063
Merged
Update IconButton readme #13063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding documentation to describe the use and functionality of the IconButton component.
kjellr
added
[Type] Developer Documentation
jasmussen
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
I dig this a lot. Thank you for doing this.
This is a great start. I would love for us, in the future, to have some additional best practices as to when you should use an icon button vs. a normal button. I would also like for us to retire a few buttons, we have a few "link buttons" at the moment, we could probably merge some. I know this is close to @aduth's heart too.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Create icon-button readme Adding documentation to describe the use and functionality of the IconButton component. * Migrate changes over to the original icon-button readme file.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Create icon-button readme Adding documentation to describe the use and functionality of the IconButton component. * Migrate changes over to the original icon-button readme file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation to describe the use and functionality of the IconButton component.
Thanks @cburton4 and @alexislloyd for help drafting this.