-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handbook: drastically improve I18N docs #12576
Conversation
Co-Authored-By: swissspidy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great, one thing I noticed was it switches from i18n
and I18n
(upper vs lowercase) on occasion and somewhat randomly. Would prefer, if possible, to standardize on one or the other (possibly only using capital I
at the start of sentences or where title case is appropriate, e.g. headers. But this is great and makes sense to land sooner rather than later :)
Co-Authored-By: swissspidy <[email protected]>
There were some many things wrong with the internationalization.md document, I don't even know where to start.
What this PR does:
_doing_it_wrong()
wp_set_script_translations()
function.Related: #12502