Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved composer.json file #1229

Merged
merged 7 commits into from
Dec 9, 2017
Merged

Improved composer.json file #1229

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d590c6b
Improved composer.json file
JulienMelissas Jun 17, 2017
44b30ad
Merge branch 'master' into better-composer-support
staylor Nov 3, 2017
7d0fd16
Merge branch 'master' into better-composer-support
JulienMelissas Dec 3, 2017
7247134
Removing the PHPCS config set Post Install Command
JulienMelissas Dec 3, 2017
4e4055f
Updating WPCS dependency
JulienMelissas Dec 3, 2017
0beea63
Updated dev dependencies, removed redundant "lint" script.
JulienMelissas Dec 4, 2017
563aa69
Update license to GPL-2.0+
ntwb Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
{
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "^0.4",
"wimg/php-compatibility": "dev-master",
"wp-coding-standards/wpcs": "dev-develop"
},
"scripts": {
"lint": "phpcs"
}
"name": "wordpress/gutenberg",
"type": "wordpress-plugin",
"license": "GPL-2.0",
"description": "Prototyping since 1440. Development hub for the editor focus in core.",
"homepage": "https://wordpress.github.io/gutenberg/",
"keywords": [
"gutenberg", "wordpress", "editor", "wp", "react", "javascript"
],
"support": {
"issues": "https://github.com/WordPress/gutenberg/issues"
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "^0.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The early 0.4.* releases had a couple of bugs. The constraint should allow the most recent anyway, but worth specifying ^0.4.3 just to be sure?

"squizlabs/php_codesniffer": "2.9.x",
Copy link
Member

@GaryJones GaryJones Dec 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for staying on the 2.9.x branch?

FWIW, the recent patch that fixed a load of code standards in WP core relied on 3.2.0-dev (master) for PHPCS.

WPCS, PHPCompatibility and the DealerDirect plugin work fine with the PHPCS 3.1.1 (stable release).

A constraint of ^3.1 would be fine.

"wimg/php-compatibility": "dev-master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current release is 8.0.1, and it now follows semantic versioning, so maybe go with ^8 as the version constraint here?

"wp-coding-standards/wpcs": "^0.14.0"
},
"require": {
"composer/installers": "~1.0"
},
"scripts": {
"lint": "phpcs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS does more than lint, and adding a script that then expects composer lint, instead of just the single command phpcs seems a little redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed. I'll remove it.

}
}
190 changes: 167 additions & 23 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.