Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Regenerate fixtures #12124

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Framework: Regenerate fixtures #12124

merged 1 commit into from
Nov 20, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 20, 2018 •
edited
Loading

Related: #4155
Blocks: #11973

Master has local changes upon running npm run fixtures:regenerate, which are the changes included here.

Testing instructions:

No failures:

npm test

@aduth aduth requested a review from dmsnell November 20, 2018 17:48
@aduth aduth mentioned this pull request Nov 20, 2018
Merged
@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Nov 20, 2018
dmsnell
dmsnell approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update! I have not (re)learned about regenerate:fixures

@aduth aduth merged commit 5a8c012 into master Nov 20, 2018
@aduth aduth deleted the fix/regenerate-fixtures-fragments branch November 20, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @dmsnell