Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve quote content #12122

Merged
merged 2 commits into from
Nov 20, 2018
Merged

preserve quote content #12122

merged 2 commits into from
Nov 20, 2018

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 20, 2018 •
edited
Loading

closes #10456

Description

Ensure content we can't handle is preserved in HTML block.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added this to the 4.5 milestone Nov 20, 2018
@ellatrix ellatrix requested a review from a team November 20, 2018 16:26
youknowriad
youknowriad approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does make sense for me to only convert if the quote block supports the content. (If it's only paragraphs inside the quote)

@youknowriad youknowriad merged commit c97cec8 into master Nov 20, 2018
@ellatrix ellatrix deleted the try/preserve-quote branch November 20, 2018 17:13
daniloercoli added a commit that referenced this pull request Nov 20, 2018
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
12dc2ba 
…rnmobile/wire-on-replace-para-block

* 'master' of https://github.com/WordPress/gutenberg:
  Remove "permalink settings" link from permalink panel. (#12121)
  preserve quote content (#12122)
  Replace gutenberg domain with default for Core blocks (#12108)
  Fix issue with disabled togglecontrol double border (#12091)
  Fix the TinyMCE init array (#10968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
[Feature] Paste
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Press This quoted content is partially lost when converting to blocks
2 participants
@ellatrix @youknowriad