Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Dotted border on hover and always show the placeholder #1210

Merged
merged 2 commits into from
Jun 19, 2017

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 16, 2017

closes #1209
closes #1250

I've used "outline" instead of "border" for the block borders to avoid a flickering effect when the border size changes.
I tried the other option (using a margin to compensate the border size, but I've found the outline method way simpler even if theoretically it's less performant).

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label Jun 16, 2017
@youknowriad youknowriad self-assigned this Jun 16, 2017
@jasmussen
Copy link
Contributor

Thanks for trying this. I think I like it. But I'd like to ... hmm... sleep on it? Maybe get some other eyes on it? @melchoyce what do you think?

@melchoyce
Copy link
Contributor

Can someone take a quick screencast/gif? I don't have the development version of the plugin set up.

@aduth
Copy link
Member

aduth commented Jun 16, 2017

@melchoyce : https://cloudup.com/clKQ5O_F4Ps

(The borders appear very very faint)

@melchoyce
Copy link
Contributor

Thanks @aduth. Pretty hard to tell – I think I'll have to try it out for myself. I'll try to get the plugin setup.

@melchoyce
Copy link
Contributor

Okay, had a chance to test this out. I... also think I like it? I don't love going from 1px on hover to 2px when active, but the dotted border doesn't look good at 2px, so maybe it's fine. I guess I'm a little ambivalent.

@jasmussen
Copy link
Contributor

It sounds like we both like the idea of a border around the whole block, but that the specific design of it needs a little more time in the oven.

Let's keep this one open, tag it "Design", and think about a good design for it. Might be worth looking at desktop apps for inspiration.

@jasmussen
Copy link
Contributor

jasmussen commented Jun 19, 2017

Per some discussions in #130, we might want to put a couple of buttons on the right side, as a counter to the movers. In that mockup, an outline all the way around on hover is extra important. Here's one that just has a 1px solid border instead:

screen shot 2017-06-19 at 09 51 52

Here's a selected block:

27260773-b5f6049c-5434-11e7-8cc4-90f6ef20f4f1

@youknowriad
Copy link
Contributor Author

Updated this PR with solid borders, we should leave the buttons for a separate issue.

@jasmussen
Copy link
Contributor

I like it, I think we should merge it and then see if we need to revisit. Thanks for working on this. 👍 👍

@youknowriad youknowriad merged commit a0bb3a3 into master Jun 19, 2017
@youknowriad youknowriad deleted the try/dotted-hover-placeholder branch June 19, 2017 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post title: Hovering should show block Blocks: Make it easier to create text blocks
4 participants