Fix empty heading anchor id leaving an empty id attribute on heading html tags #11900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #11663
This PR resolves the bug where an empty anchor id on a heading block would result in a stray empty id attribute on the heading html tag. This solution updates the editor anchor hook to check that the anchor id attribute is not an empty string before saving it as additional props. Also adds a test to cover this behaviour.
How has this been tested?
addSaveProps
method to check that an empty string passed in toextraProps
does not result in an id being created.Steps to reproduce the behaviour (from issue #11663):
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: