Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with image initial size #11846

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Fix issues with image initial size #11846

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
968d74b
Fix issues with image initial size
Nov 14, 2018
fab0f03
Create proof of concept instead.
Nov 14, 2018
dfdd839
Use buffered max-width.
jasmussen Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/block-library/src/image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,13 @@ class ImageEdit extends Component {
const minWidth = imageWidth < imageHeight ? MIN_SIZE : MIN_SIZE * ratio;
const minHeight = imageHeight < imageWidth ? MIN_SIZE : MIN_SIZE / ratio;

// With the current implementation of ResizableBox, an image needs an explicit pixel value for the max-width.
// In absence of being able to set the content-width, this max-width is currently dictated by the vanilla editor style.
// The following variable adds a buffer to this vanilla style, so 3rd party themes have some wiggleroom.
// This does, in most cases, allow you to scale the image beyond the width of the main column, though not infinitely.
// @todo It would be good to revisit this once a content-width variable becomes available.
const maxWidthBuffer = maxWidth * 2.5;

let showRightHandle = false;
let showLeftHandle = false;

Expand Down Expand Up @@ -577,9 +584,9 @@ class ImageEdit extends Component {
} : undefined
}
minWidth={ minWidth }
maxWidth={ maxWidth }
maxWidth={ maxWidthBuffer }
minHeight={ minHeight }
maxHeight={ maxWidth / ratio }
maxHeight={ maxWidthBuffer / ratio }
lockAspectRatio
enable={ {
top: false,
Expand Down