-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/image block #11377
Closed
Closed
Update/image block #11377
Commits on Jun 11, 2018
-
- Add `srcset` and `sizes` inside the editor. - Add `data-wp-attachment-id` and `ata-wp-percent-width` to the img tag. Will be used on the front-end to properly set `srcset` and `sizes`, and also img `width` and `height` where missing. - Improve setting/resetting the image dimensions.
Configuration menu - View commit details
-
Copy full SHA for 9d5091f - Browse repository at this point
Copy the full SHA 9d5091fView commit details -
Update image block, add srcset to attachment data
Add `srcset` to the attachment data from the API and to the data in the media modal.
Configuration menu - View commit details
-
Copy full SHA for 4b3d889 - Browse repository at this point
Copy the full SHA 4b3d889View commit details -
Configuration menu - View commit details
-
Copy full SHA for be16a73 - Browse repository at this point
Copy the full SHA be16a73View commit details
Commits on Aug 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 041d1a5 - Browse repository at this point
Copy the full SHA 041d1a5View commit details -
Fixes after merging from master. (NOTE: JSHint still throws errors an…
…d warnings after ignore!)
Configuration menu - View commit details
-
Copy full SHA for 64648c1 - Browse repository at this point
Copy the full SHA 64648c1View commit details
Commits on Sep 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 28d9315 - Browse repository at this point
Copy the full SHA 28d9315View commit details
Commits on Sep 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0a73bc9 - Browse repository at this point
Copy the full SHA 0a73bc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d0d17e - Browse repository at this point
Copy the full SHA 1d0d17eView commit details
Commits on Sep 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dbba831 - Browse repository at this point
Copy the full SHA dbba831View commit details
Commits on Oct 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b6dc78f - Browse repository at this point
Copy the full SHA b6dc78fView commit details
Commits on Oct 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 108ea54 - Browse repository at this point
Copy the full SHA 108ea54View commit details
Commits on Oct 15, 2018
-
Most functionality works as expected. Still todo: image dimensions by entering width or height. These need to override the `scale` attribute.
Configuration menu - View commit details
-
Copy full SHA for 22207ba - Browse repository at this point
Copy the full SHA 22207baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cb8189 - Browse repository at this point
Copy the full SHA 4cb8189View commit details -
- Don't save srcset and sizes in block props. - Better names? - Clean up few eslint-disable-*.
Configuration menu - View commit details
-
Copy full SHA for ae95eab - Browse repository at this point
Copy the full SHA ae95eabView commit details
Commits on Oct 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d9ef233 - Browse repository at this point
Copy the full SHA d9ef233View commit details
Commits on Oct 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0aea270 - Browse repository at this point
Copy the full SHA 0aea270View commit details
Commits on Oct 19, 2018
-
Tweak some names, clean up few things, simplify the php parts, fall back to the original block html if some image data is not there.
Configuration menu - View commit details
-
Copy full SHA for a476203 - Browse repository at this point
Copy the full SHA a476203View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d37181 - Browse repository at this point
Copy the full SHA 8d37181View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0899e - Browse repository at this point
Copy the full SHA 9d0899eView commit details
Commits on Oct 20, 2018
-
- Better handling of existing (old) image blocks and just uploaded images. - Add support for scaled external images.
Configuration menu - View commit details
-
Copy full SHA for 22007e6 - Browse repository at this point
Copy the full SHA 22007e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5be6f - Browse repository at this point
Copy the full SHA 5b5be6fView commit details
Commits on Nov 1, 2018
-
Added few more block props that are passed to the PHP filters in WP. Now themes and plugins can easily decide how to handle all aspects of rendering the image block on the front-end.
Configuration menu - View commit details
-
Copy full SHA for 5525986 - Browse repository at this point
Copy the full SHA 5525986View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83ca683 - Browse repository at this point
Copy the full SHA 83ca683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15520ea - Browse repository at this point
Copy the full SHA 15520eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c5563 - Browse repository at this point
Copy the full SHA 17c5563View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a98975 - Browse repository at this point
Copy the full SHA 6a98975View commit details
Commits on Nov 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e8dfda2 - Browse repository at this point
Copy the full SHA e8dfda2View commit details
Commits on Nov 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e1a5a86 - Browse repository at this point
Copy the full SHA e1a5a86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39bbfec - Browse repository at this point
Copy the full SHA 39bbfecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5102f35 - Browse repository at this point
Copy the full SHA 5102f35View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.