Reduce frequency of actions updating isCaretWithinFormattedText #11235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly triggering them when they cause a change in state
talldan
added
[Type] Task
4 tasks
ellatrix
reviewed
Oct 30, 2018
| if ( start !== this.state.start || end !== this.state.end ) { | ||
| const isCaretWithinFormattedText = this.props.isCaretWithinFormattedText; |
There was a problem hiding this comment.
When there's only one property I don't really have a preference either way.
There was a problem hiding this comment.
I agree when it doesn't get assigned, but in this case it duplicates isCaretWithinFormattedText, so it does make it a bit less verbose.
ellatrix
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the issue mentioned in #10983 (comment) by only triggering a state change when needed.
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: