Fix converting a reusable block with nested blocks into a static block #11188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CONVERT_BLOCK_TO_STATIC effect needs to handle the case where the block being converted has inner blocks.
noisysocks
added
[Type] Bug
noisysocks
added
the
[Feature] Nested / Inner Blocks
youknowriad
reviewed
Oct 29, 2018
| newBlocks = [ createBlock( | ||
| referencedBlock.name, | ||
| referencedBlock.attributes, | ||
| referencedBlock.innerBlocks |
There was a problem hiding this comment.
I think we should clone the blocks before calling this:
- Insert the reusable block twice
- Convert one of them to regular
- Edit the regular blocks (notice they change in both blocks)
There was a problem hiding this comment.
Good catch! Fixed in a7464db.
By using cloneBlock(), we correctly make a copy of the innerBlocks which means that updates to one block don't affect another.
|
Can you please reconsider and include this in 4.2? I know I’m been nagging about this issue and I promise this is the last time, whatever you decide 😁 |
|
@noisysocks - sorry - was a bit slow to review this. The only thing I spotted is that I can now nest a reusable block inside of itself, which causes an infinite recursion and my chrome tab ran out of memory! I know, I know, but I had to try it! 🤣 Want me to create an issue about that? |
|
@talldan I don't think it's related to this PR but I saw an issue about it (created yesterday I think) |
|
Thanks, found it - #11206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9278.
The
CONVERT_BLOCK_TO_STATICeffect needs to handle the case where the block being converted has inner blocks.Testing