-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n context for resolving invalid blocks #10779
Conversation
Yes, thank you, these screenshots are much more explicative. |
06bab87
to
4593fb8
Compare
Thanks for the additional suggestions, @gAllegr. This is good to be learning. I made an update based on your comments. How does the latest look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: is the line break needed at all?
// translators: Dialog title to fix block content
title={ __( 'Resolve Block' ) }
other than that question: good to merge, the notes and syntactic case are good.
The parser is a little picky, and while the comment doesn't need to strictly be a leading comment of the translation call, it does need to be a leading comment of one of its parents in the AST hierarchy. This might actually work here as the leading comment of the attribute assignment, but it's worth verifying. tl;dr The parser doesn't strictly consider "previous line", it considers leading comments of its AST ancestry which occur on the current or previous line. See gutenberg/packages/babel-plugin-makepot/src/index.js Lines 109 to 157 in a548961
|
Looks ok to me |
Description
This is a simple PR to add i18n context for "Resolve" and "Resolve Block" strings to resolve translation concerns from this comment.
@gAllegr, does this address your issue with the strings?
Screenshots