Scripts: Add bare handling for lint-js script (no zero config) #10504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Status] In Progress
gziolo
force-pushed
the
add/scripts-lint-js
branch
from
6bd6c68
to
085b66c
Compare
gziolo
commented
Oct 11, 2018
| @@ -34,8 +34,10 @@ | |||
| "@wordpress/babel-preset-default": "file:../babel-preset-default", | |||
| "@wordpress/jest-preset-default": "file:../jest-preset-default", | |||
| "@wordpress/npm-package-json-lint-config": "file:../npm-package-json-lint-config", | |||
| "babel-eslint": "8.0.3", | |||
There was a problem hiding this comment.
I wanted to bump babel-eslint and eslint but it throws an error with the latest version. We should tackle it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
wp-scripts lint-jsscript to the@wordpress/scriptspackage. The idea is to have it working with #7965 which will offer zero config support when it's ready. At the moment this is just proxy overeslintso it only makes it easier to maintain your dependencies for tools.How has this been tested?
npm run lint-jsinside Gutenberg should work as before.Checklist: