Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to filter $editor_settings in /lib/client-assets.php #7400

Closed
dannydehaan opened this issue Jun 20, 2018 · 2 comments
Closed

Possibility to filter $editor_settings in /lib/client-assets.php #7400

dannydehaan opened this issue Jun 20, 2018 · 2 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Enhancement A suggestion for improvement.

Comments

@dannydehaan
Copy link

dannydehaan commented Jun 20, 2018

Hi,

When working on my dev environment, I don't want Gutenberg autosaves a post every 10 seconds. With a filter I could set the interval to 3600 or something, like this:

add_filter( 'gutenberg_editor_settings', function( $gutenberg_editor_settings ) {
    $gutenberg_editor_settings['autosaveInterval'] = 3600;

    return $gutenberg_editor_settings;
} );
dannydehaan pushed a commit to dannydehaan/gutenberg that referenced this issue Jun 20, 2018
@Soean Soean added [Type] Enhancement A suggestion for improvement. [Feature] Extensibility The ability to extend blocks or the editing experience labels Jun 20, 2018
@danielbachhuber
Copy link
Member

Specific to autosave intervals, there was some conversation on #6257 (comment) about respecting the AUTOSAVE_INTERVAL constant. However, the product goal for Gutenberg is to produce a "Google Docs-like experience" (i.e. your document is always saved), so AUTOSAVE_INTERVAL may no longer be relevant.

When working on my dev environment, I don't want Gutenberg autosaves a post every 10 seconds.

Is there some practical implication of this, or is this simply a matter of personal preference?

@pento
Copy link
Member

pento commented Sep 14, 2018

Per the discussion on #7400, there's already a method in place to change the editor settings, so I'm going to close this issue.

@pento pento closed this as completed Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants