Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: No space on the left or right of the menu in mobile view #69156

Open
2 of 6 tasks
t-hamano opened this issue Feb 12, 2025 · 3 comments
Open
2 of 6 tasks

Site Editor: No space on the left or right of the menu in mobile view #69156

t-hamano opened this issue Feb 12, 2025 · 3 comments
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

Description

As you can see, in the Gutenberg trunk there is no left or right spacing in the mobile view. To make it easier to see, I have artificially added focus to some elements.

WP 6.7 Gutenberg trunk
Image Image

After investigation, it seems that this issue was caused by PR #67321 and PR #67199. I think this is not intended.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@t-hamano t-hamano added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release Mobile Web Viewport sizes for mobile and tablet devices labels Feb 12, 2025
@t-hamano t-hamano self-assigned this Feb 12, 2025
@afercia
Copy link
Contributor

afercia commented Feb 12, 2025

Good catch thanks. Relevant history:
#66606, #66606 (comment), #67321 and #67575

Some of the elements in the navigation panel did use negative left and right margins even before the changes in #66606 and the CSS was targeting the class of the ItemGroup .components-item-group which is a bad practice. From there, a series of changes were implemented to avoid the usage of base components CSS classes. This may have had an impact in the mobile view. Anyways, these negative margins should be reduced in the mobile view or, alternatively, the usage of negative margins could be entirely reconsidered.

@afercia afercia moved this to 📥 Todo in WordPress 6.8 Editor Tasks Feb 12, 2025
@rinkalpagdar
Copy link
Contributor

I want to work on this issue.

@t-hamano
Copy link
Contributor Author

@rinkalpagdar Thanks for your interest in this issue, but since this issue is related to #68907, it might be better to tackle it after #68907 is merged. Please see #68907 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Regression Related to a regression in the latest release
Projects
Development

No branches or pull requests

3 participants