Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link button to Verse block toolbar #6696

Closed
ZebulanStanphill opened this issue May 11, 2018 · 4 comments
Closed

Add link button to Verse block toolbar #6696

ZebulanStanphill opened this issue May 11, 2018 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented May 11, 2018

@nfmohit
Copy link
Member

nfmohit commented May 11, 2018

Thanks for creating the issue @SuperGeniusZeb!

Achieving this'd require a pretty simple change but I'm wondering if the link control was intentionally not included in the "verse" block. I do not see a reason to do so personally though, it could be because I might be missing something. Awaiting some further feedback here from others regarding the link control in the "verse" block.

cc/ @karmatosed @gziolo (sorry to bump but would love to see your feedback here)

@gziolo
Copy link
Member

gziolo commented May 11, 2018

@iseulde might be better suited to answer this question than I do :)

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels May 11, 2018
@ellatrix
Copy link
Member

@mtias removed the link button: bd676b5#r126746200

@karmatosed
Copy link
Member

I'm not sure we should add this in, lets close for now and we can always review later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

5 participants