Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text alignment controls to Verse block toolbar #6695

Closed
ZebulanStanphill opened this issue May 11, 2018 · 4 comments
Closed

Add text alignment controls to Verse block toolbar #6695

ZebulanStanphill opened this issue May 11, 2018 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback.

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented May 11, 2018

The Verse block seems to be missing something

The Heading, Paragraph, and Subheading blocks all have text alignment controls in their block toolbars. (The Cover Image and Quote blocks do as well, but those blocks will soon be updated to use nested Paragraph and Heading blocks, so they do not really count.) For some reason, the Verse block currently does not.

Solution

Just add the same text alignment button controls to the block toolbar of the Verse block.

Related Issues and/or PRs

@ZebulanStanphill ZebulanStanphill changed the title Add text alignment buttons to Verse block toolbar Add text alignment controls to Verse block toolbar May 11, 2018
@gziolo gziolo added [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels May 11, 2018
@danielbachhuber
Copy link
Member

@SuperGeniusZeb Can you share an example use-case for this enhancement?

@danielbachhuber danielbachhuber added the Needs Design Feedback Needs general design feedback. label May 21, 2018
@ZebulanStanphill
Copy link
Member Author

@danielbachhuber Making poetry/music lyrics appear centered, especially when surrounded by standard non-poetic text (Paragraph or Heading blocks) that are centered, as having the Verse blocks use a different text alignment from surrounding Paragraph blocks looks weird.

image

@danielbachhuber
Copy link
Member

Good example, thanks @SuperGeniusZeb

@karmatosed
Copy link
Member

Closing as now merged in #6700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants